Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on big endian targets #69

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jan 29, 2023

Tested with cross test --target powerpc-unknown-linux-gnu. Fixes #68. I have not tested on a big endian system / emulator beyond running these tests.

Tested with `cross test --target powerpc-unknown-linux-gnu`. Fixes
linebender#68. I have not tested on
a big endian system / emulator beyond running these tests.
@jamessan
Copy link
Contributor

Should cross test for big-endian get added to CI, too?

@CryZe
Copy link
Contributor

CryZe commented Jan 29, 2023

Should cross test for big-endian get added to CI, too?

Yeah I think it should.

@RazrFalcon
Copy link
Collaborator

RazrFalcon commented Jan 29, 2023

@ids1024 Is there a reason you run PowerPC on mac and not linux?

Whoops. My bad. I thought we use macos for aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most integration tests fail on big-endian systems
4 participants