This repository was archived by the owner on Jul 15, 2024. It is now read-only.
Initialize ns_window on mac #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were setting ns_view but not ns_window, which was causing the query to fetch scale to fail, and thus dpi wrong. I'm not 100% sure we should be calling the `window` method to get this, we could store the NSWindow pointer in the WindowHandle. The main reason we didn't do this was to support the VST use case, but that's not actively being developed. In any case, I think this is probably "good enough."
|
Hrm. According to the code, we're grabbing the scale from the view and not the window: let scale_factor: CGFloat = unsafe { msg_send![*self.nsview.load(), backingScaleFactor] };Even without this change, scale is currently returning 2.0 for me which should be correct. |
|
It's not the grabbing of the scale factor, it's the setting of it when creating the MetalLayer surface. This particular code is going away, but it's very easy to imagine that other glazier clients will also depend on ns_window being initialized. |
|
Oh! I was looking for references to NSWindow and scale factor and couldn't find them. This explains why :) |
dfrg
approved these changes
Nov 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting ns_view but not ns_window, which was causing the query to fetch scale to fail, and thus dpi wrong.
I'm not 100% sure we should be calling the
windowmethod to get this, we could store the NSWindow pointer in the WindowHandle. The main reason we didn't do this was to support the VST use case, but that's not actively being developed.In any case, I think this is probably "good enough."