Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta derivation for from_lists #83

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix meta derivation for from_lists #83

merged 1 commit into from
Feb 24, 2025

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Feb 24, 2025

There was a bug in the code, because pack assumed that given empty array is a "flat" array, not "lists" array

@hombit hombit requested a review from dougbrn February 24, 2025 21:08
Copy link

Before [e1e1993] <v0.3.2> After [ee40ee8] Ratio Benchmark (Parameter)
821±2ms 828±6ms 1.01 benchmarks.NestedFrameQuery.time_run
137M 137M 1 benchmarks.NestedFrameAddNested.peakmem_run
270±3ms 269±0.9ms 1 benchmarks.NestedFrameAddNested.time_run
139M 139M 1 benchmarks.NestedFrameQuery.peakmem_run
135M 135M 1 benchmarks.NestedFrameReduce.peakmem_run
282±2ms 282±1ms 1 benchmarks.NestedFrameReduce.time_run

Click here to view all benchmarks.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (e1e1993) to head (67c36e7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files           9        9           
  Lines         242      242           
=======================================
  Hits          231      231           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit merged commit 60c93da into main Feb 24, 2025
9 checks passed
@hombit hombit deleted the from_lists-meta branch February 24, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants