Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #9

Closed
wants to merge 17 commits into from
Closed

Fix build #9

wants to merge 17 commits into from
+9 −6

Conversation

tomwhite
Copy link
Collaborator

Small change to debug the build with goal of solving #8.

@tomwhite tomwhite requested a review from horta March 31, 2022 11:56
@tomwhite
Copy link
Collaborator Author

Opened horta/zlib.install#13 to fix the Windows build

@tomwhite tomwhite force-pushed the workflow_dispatch branch from c35bf81 to 41f66cb Compare March 31, 2022 13:28
@tomwhite tomwhite changed the title Allow GitHub Action builds to be triggered manually Fix build Mar 31, 2022
@tomwhite
Copy link
Collaborator Author

Tests are failing for almosthere: https://github.com/limix/cbgen/runs/5772158281?check_suite_focus=true

@tomwhite tomwhite mentioned this pull request Mar 31, 2022
Merged
@tomwhite
Copy link
Collaborator Author

Status: tests pass on ubuntu and macos. Wheels build on macos, but not on ubuntu. Tests and wheels not working on windows.

@tomwhite tomwhite marked this pull request as draft March 31, 2022 14:30
@tomwhite
Copy link
Collaborator Author

Tests are passing everywhere now since horta/zlib.install#13 was fixed.

The wheels build is still not working on ubuntu, see https://github.com/limix/cbgen/runs/6523063318?check_suite_focus=true. Any thought on how to fix this @horta?

@tomwhite
Copy link
Collaborator Author

tomwhite commented May 20, 2022 •
edited
Loading

@horta why does cbgen need a progress bar library (https://github.com/horta/almosthere)? I can't see where it is used either (but I may be missing something).

@horta
Copy link
Collaborator

horta commented May 22, 2022

That is because bgen depends on it: https://github.com/limix/bgen/blob/961ed6e875169d2c753a5d1e5ef52104017f0030/src/metafile_write.h#L96

I'm not sure if that is necessary anymore (it depends how fast it is but I don't remember...).

@horta
Copy link
Collaborator

horta commented May 22, 2022

Culprit (Windows SDK): microsoft/vcpkg#15035 (comment)

@horta
Copy link
Collaborator

horta commented May 22, 2022

Workaround ?: ApexAI/iceoryx@dc14985

@tomwhite
Copy link
Collaborator Author

Thanks @horta. I tried the workaround (windows-latest), but unfortunately it still failed: https://github.com/limix/cbgen/runs/6554207174?check_suite_focus=true. Also, ubuntu is failing too.

Not sure what to try next as I'm not very familiar with the code.

horta added 6 commits May 29, 2022 22:37
@horta
Update test-and-deploy.yml
c79e9cc 
Try to fix "Warning: Environment variable CMAKE_GENERATOR_PLATFORM will be ignored, because CMAKE_GENERATOR is not set.".
@horta
vs19
7a30f24
@horta
Ninja?
09f1bf0
@horta
quote
38702f9
@horta
remove system settings
cda2097
@horta
windows and quotes
2d70ea1
@horta
Copy link
Collaborator

horta commented May 30, 2022

Hey @tomwhite , could you edit ci/win-deps to have:

if [[ $BITS == "32" ]]
then
    export CMAKE_GENERATOR_PLATFORM=Win32
    export CMAKE_GENERATOR="Visual Studio 17 2022"
    PREFIX="/c/Program Files (x86)"
else
    export CMAKE_GENERATOR_PLATFORM=x64
    export CMAKE_GENERATOR="Visual Studio 17 2022"
    PREFIX="/c/Program Files"
fi

?

I think that will sort out the remainig building error...

@horta
Copy link
Collaborator

horta commented May 31, 2022

Almost:

cp: cannot stat '/c/Program Files (x86)/zlib/bin/zlib.dll': No such file or directory

I will be releasing a new bgen version today with all those libraries built-in so we don't see those errors anymore.

@tomwhite
Copy link
Collaborator Author

Great! Thanks @horta.

@tomwhite
Copy link
Collaborator Author

I will be releasing a new bgen version today with all those libraries built-in so we don't see those errors anymore.

Any updates on the bgen release @horta? I couldn't see it when I checked. Thanks.

@horta
Copy link
Collaborator

horta commented Jun 22, 2022

Hi @tomwhite , could you ping my this weekend so I dont forget it? It was nearly done but I had to travel back to UK and then I forgot everything I was doing hehe

@tomwhite
Copy link
Collaborator Author

@horta ping (as requested)!

@horta
Copy link
Collaborator

horta commented Jul 12, 2022

Hey @tomwhite , could you take a look at the main repo? It is building for manylinux2014 and macos but I had to disable Windows for now (have a look at the commit message, please).

It was a nightmare to refactor to building process to a much simpler (still complex) one, but I'm depending on the Python poetry 1.2.x beta releases, and I'm waiting for the new beta release to try Windows again.

(If you have an idea on how to build for windows, please, let me know). I feel that we are close to a simple building workflow for it.

@tomwhite
Copy link
Collaborator Author

@horta this is working for me on Linux - thanks for fixing it.

I don't have an experience or suggestions for the Windows builds I'm afraid. But it looks like a new poetry 1.2.x beta release is out now.

@CarlKCarlK
Copy link
Collaborator

CarlKCarlK commented Jul 19, 2022 via email

@horta
Copy link
Collaborator

horta commented Jul 20, 2022

Gonna give a go with Poetry 1.2.0b3

@horta
Copy link
Collaborator

horta commented Jul 20, 2022

Trying it here: https://github.com/limix/cbgen/tree/try-win

@CarlKCarlK
Copy link
Collaborator

CarlKCarlK commented Jul 20, 2022 via email

@horta
Copy link
Collaborator

horta commented Jul 21, 2022

Hi @CarlKCarlK =)

Could you give it a try?

Theoretically, you need:

  • Python 3.8 or above installed
  • pipx (python -m pip install --user pipx) or ((python3 -m pip install --user pipx)
  • pipx install poetry==1.2.0b3

From the project folder, you can then type: poetry install

That is the step in which the building process takes forever. The first step of this process is actually installing cmake and cffi python packages, which should not take long as pypi has wheels for them...

@CarlKCarlK
Copy link
Collaborator

CarlKCarlK commented Jul 22, 2022 via email

@CarlKCarlK
Copy link
Collaborator

CarlKCarlK commented Oct 11, 2022 via email

@CarlKCarlK
Copy link
Collaborator

CarlKCarlK commented Oct 11, 2022 via email

@tomwhite tomwhite closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horta horta Awaiting requested review from horta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwhite @horta @CarlKCarlK