-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the phpunit requirement (build on travis with version 5.4.0) #121
Conversation
Please use a version constraint that allows supported versions of phpunit. PHPUnit 4 is eol since 3 February 2017 It's better to use this constraint: |
Thats right. i will check the dependency and update them. |
I think it's better to deprecate some old (and unsupported) php versions, instead of making workarounds for phpunit versions. I will open a PR later today to propose a fix! |
Jeah that will be great, i will wait for it |
you also need to adjust the script in .travis.yml to use the composer installed phpunit |
I close this PR |
Hey everybody,
I want to add a feature and checked first the unit tests. I found no reference to used phpunit version. So i added it as a dev-requirement (version used from travis build).
Greetings