Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the phpunit requirement (build on travis with version 5.4.0) #121

Closed
wants to merge 7 commits into from

Conversation

sseidelmann
Copy link

Hey everybody,

I want to add a feature and checked first the unit tests. I found no reference to used phpunit version. So i added it as a dev-requirement (version used from travis build).

Greetings

@acrobat
Copy link
Contributor

acrobat commented Jul 13, 2017

Please use a version constraint that allows supported versions of phpunit. PHPUnit 4 is eol since 3 February 2017

It's better to use this constraint:
"phpunit/phpunit": "^5.5|^6.0"

@sseidelmann
Copy link
Author

Thats right. i will check the dependency and update them.

@acrobat
Copy link
Contributor

acrobat commented Jul 13, 2017

I think it's better to deprecate some old (and unsupported) php versions, instead of making workarounds for phpunit versions. I will open a PR later today to propose a fix!

@sseidelmann
Copy link
Author

Jeah that will be great, i will wait for it

@lsmith77
Copy link
Contributor

you also need to adjust the script in .travis.yml to use the composer installed phpunit

@acrobat
Copy link
Contributor

acrobat commented Jul 14, 2017

@lsmith77 I've create PR #124 to bump to php version and require phpunit (+ test fixes).

@sseidelmann
Copy link
Author

I close this PR

@sseidelmann sseidelmann deleted the add_phpunit_requirement branch July 14, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants