Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LoggerInterface to AmazonS3Resolver #70

Merged
merged 1 commit into from
May 7, 2012

Conversation

havvg
Copy link
Contributor

@havvg havvg commented May 7, 2012

@neilferreira The logger has been added, does it work out for you?

I also added tests for the previous issues.

* add AmazonS3ResolverTest
@lsmith77 lsmith77 merged commit 9a09c03 into liip:master May 7, 2012
@neilferreira
Copy link

This has ended up working a charm. I think you're lucky Stof isn't around as he probably would have made you change 's3_response' into 's3Response' and remove that last comma from the ->warn call array.

I'm not sure why you are using warn rather than error, looking at https://github.com/Seldaek/monolog - tbh the fact that a user has specifically setup their images to serve from s3, due to most likely having a desperate need to serve images at lesser cost and/or server load, this would probably grant a higher error code. Lets put it this way, in Australia bandwidth is so damn expensive that having data files not served off s3 on a high traffic website does cost you hundreds and hundreds of dollars.

Thanks for all the fixes, I think I'm ready to go into production with this now.

cheers

@stof
Copy link
Contributor

stof commented May 7, 2012

@neilferreira I would have asked to add the comma if missing, and to turn 's3Response to 's3_response (array keys are using underscores) if they were the other way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants