Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws_s3.rst to follow the currently mainted library #636

Closed
wants to merge 1 commit into from

Conversation

appeltaert
Copy link

  • Changed the link to new one
  • Changed the config to follow the new factory, and a block below it for the deprecated verison
  • Added the mandatory version parameter

- Changed the link to new one
- Changed the config to follow the new factory, and a block below it for the deprecated verison
@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Sep 24, 2015
@dincho
Copy link

dincho commented Oct 3, 2015

I'm getting Invalid type for path "liip_imagine.resolvers.images_s3.aws_s3.client_config.XXXXX". Expected scalar, but got array. with below config:

liip_imagine:
    cache:      images_s3
    resolvers:
        images_s3:
            aws_s3:
                client_config:
                    credentials: 
                        key: %amazon_s3.key%
                        secret: %amazon_s3.secret%
                    region: %amazon_s3.region%
                    version: %amazon_s3.version%
                bucket:     %amazon_s3.images_cache_bucket%
                proxies:    %amazon_s3.proxies%

This is because client_config prototype accepts only scalars, but credentials is array.
AwsS3ResolverFactory should be modified to reflect this configuration.

@dincho
Copy link

dincho commented Oct 3, 2015

Oh, this is service configuration sorry. Unrelated comment.

@lsmith77
Copy link
Contributor

see this comment here #620 (comment)

@makasim
Copy link
Collaborator

makasim commented Dec 28, 2015

fixed in #685. available since 1.4.1

@makasim makasim closed this Dec 28, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants