fix thumbnail allow_upscale option #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test? |
lsmith77
added
the
State: Reviewing
| $ratio = max($width / $origWidth, $height / $origHeight); | ||
| $resizeFilter = new Resize(new Box(round($origWidth * $ratio), round($origHeight * $ratio))); | ||
| $image = $resizeFilter->apply($image); | ||
| } |
There was a problem hiding this comment.
This is duplicate code. Why not just do:
$upscale = new UpscaleFilterLoader;
$image = $upscale->load($image, array('min' => array($width, $height));
There was a problem hiding this comment.
cab you bake this into a PR of your own?
|
ping |
|
please rebase on master to get the test fixed |
|
Need it ! |
|
ping |
lsmith77
removed
the
State: Reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix thumbnail allow_upscale option
For smaller image, resize first before creating thumbnail.
Resolve #560 and #428