Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check $filters is an array #596

Merged
merged 2 commits into from
Apr 24, 2015
Merged

Check $filters is an array #596

merged 2 commits into from
Apr 24, 2015

Conversation

trsteel88
Copy link
Contributor

Every now and again I get the following error:

[2015-04-24 14:19:57] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\ContextErrorException: "Catchable Fatal Error: Argument 3 passed to Liip\ImagineBundle\Imagine\Cache\Signer::check() must be of the type array, string given, called in application/releases/20150424033514/vendor/liip/imagine-bundle/Liip/ImagineBundle/Controller/ImagineController.php on line 130 and defined" at application/releases/20150424033514/vendor/liip/imagine-bundle/Liip/ImagineBundle/Imagine/Cache/Signer.php line 37 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\ContextErrorException(code: 0): Catchable Fatal Error: Argument 3 passed to Liip\\ImagineBundle\\Imagine\\Cache\\Signer::check() must be of the type array, string given, called in application/releases/20150424033514/vendor/liip/imagine-bundle/Liip/ImagineBundle/Controller/ImagineController.php on line 130 and defined at application/releases/20150424033514/vendor/liip/imagine-bundle/Liip/ImagineBundle/Imagine/Cache/Signer.php:37)"} []

I believe this is because someone is modifying the query parameters for runtime config requests. This patch resolves this issue.

@lsmith77
Copy link
Contributor

looks sensible to me

makasim added a commit that referenced this pull request Apr 24, 2015
@makasim makasim merged commit e24256a into liip:master Apr 24, 2015
@makasim
Copy link
Collaborator

makasim commented Apr 24, 2015

Good catch! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants