[1.0][resolver] Decouple WebPathResolver from http request. Simplify its logic. #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@havvg ping |
| @@ -23,7 +23,7 @@ function isStored($path, $filter); | |||
| * @param string $path The path where the original file is expected to be. | |||
| * @param string $filter The name of the imagine filter in effect. | |||
| * | |||
| * @return string The URL of the cached image. | |||
| * @return string The ABSOLUTE URL of the cached image. | |||
The new name is misleading. The resolver has nothing to do with the web path (even if the previous implementation extended the web path resolver). It's more a |
disagree, it expects that given |
|
@havvg fix ABSOLUTE and test name, could we address provider maybe later? |
|
Yeah, let's postpone this one for now :) |
havvg
added a commit
that referenced
this pull request
Feb 7, 2014
…e-from-request [1.0][resolver] Decouple WebPathResolver from http request. Simplify its logic.
|
thanks! we are moving forward fast 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce next features:
WebPathResolverandNoCacheWebPathResolverno more coupled to request. Could be executed in cli. You just have to configure parameters used by request context as default values.AbstractFilesystemResolverwas removed.NoCacheResolverwas renamed toNoCacheWebPathResolversince could only work with local images. I think previous name would confuse someone.WebPathResolverTestare units and does not use real filesystem any more.WebPathResolverrelly on filesystem services everywhere.CreateCacheDirectoriesCompilerPasswas removed as it seems filesystem does its job very well (I tested it in different scenarios).