Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve phpcr loader doc #177

Merged
merged 1 commit into from
May 3, 2013
Merged

improve phpcr loader doc #177

merged 1 commit into from
May 3, 2013

Conversation

dbu
Copy link
Member

@dbu dbu commented May 3, 2013

had a hard time figuring out that things where not working anymore because the signature of the phpcr loader changed...

is there a reason why this bundle does not allow to configure the phpcr loader service but recommends defining your own service?

see also symfony-cmf/media-bundle#3 - i expect somebody will soon attempt to improve the phpcr loader support.

@lsmith77
Copy link
Contributor

lsmith77 commented May 3, 2013

So far we just left the bundle config simpler by not trying to support all possible loaders .. especially i expect a lot of customization of the services. however i am not opposed to making the out of the box experience nicer by supporting some sensible defaults.

lsmith77 added a commit that referenced this pull request May 3, 2013
@lsmith77 lsmith77 merged commit 8df043c into master May 3, 2013
@lsmith77 lsmith77 deleted the phpcr-loader-doc branch May 3, 2013 11:06
@dbu
Copy link
Member Author

dbu commented May 3, 2013

if we where going through a the bundle configuration, we would have noticed the config is incomplete. this way, i had to realize why i just get no image... but yes, it would make the config more complicated, but as it will be optional sections i think that would not be too bad.
lets see when/if it happens...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants