Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slog: update deps for LND, aperture, lndclient and btclog #496

Merged
merged 9 commits into from
Mar 5, 2025
Merged

slog: update deps for LND, aperture, lndclient and btclog #496

merged 9 commits into from
Mar 5, 2025

Conversation

ellemouton
Copy link
Member

Depends on:

Update the LND, aperture, lndclient and btclog deps.
This includes upgrading the logging framework to the V2 framework. This
new framework lets us deprecate the maxlogfiles and
maxlogfilesize config options.

@ellemouton ellemouton marked this pull request as draft March 4, 2025 16:24
@ellemouton ellemouton force-pushed the slog branch 6 times, most recently from 909c6b1 to 0429225 Compare March 4, 2025 17:55
@ellemouton ellemouton force-pushed the slog branch 4 times, most recently from cb5cb21 to 7d89a63 Compare March 5, 2025 09:45
@ellemouton ellemouton marked this pull request as ready for review March 5, 2025 09:50
@ellemouton ellemouton requested a review from guggero March 5, 2025 09:50
guggero
guggero reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Can we also bump the Go version to 1.23.6 in the different Docker files (and everywhere else we might have an old version)?

@ellemouton ellemouton requested a review from guggero March 5, 2025 10:46
guggero
guggero approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot! LGTM 🎉

bhandras
bhandras approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕

@ellemouton ellemouton removed the request for review from ViktorTigerstrom March 5, 2025 12:25
@guggero guggero merged commit fc9532f into lightninglabs:master Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellemouton @bhandras @guggero