Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddInvoice: expose field Private #208

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

starius
Copy link
Contributor

@starius starius commented Feb 19, 2025

Description

Previously we'd always pass Private=true.

Fix #207

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@guggero
Copy link
Member

guggero commented Feb 19, 2025

I guess this could go into master branch though? As this flag should be present on 0.17 already. Can then rebase all branches.

@starius starius marked this pull request as ready for review February 19, 2025 13:30
Previously we'd always pass Private=true.

Fix lightninglabs#207
@starius starius force-pushed the add-invoice-private branch from 143ee65 to a04db5f Compare February 19, 2025 13:37
@starius starius changed the base branch from lnd-18-4 to master February 19, 2025 13:37
@starius
Copy link
Contributor Author

starius commented Feb 19, 2025

I changed base branch to master.

@guggero guggero merged commit 3473642 into lightninglabs:master Feb 19, 2025
1 check passed
@guggero
Copy link
Member

guggero commented Feb 19, 2025

I rebased all branches and pushed the following tags: v0.17.4-9 v0.18.0-8 v0.18.4-12 v0.19.0-1

@starius starius deleted the add-invoice-private branch February 19, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded Private Invoice Flag
3 participants