Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop cosmos-sdk and call manifestd #23

Merged
merged 26 commits into from
Jun 27, 2024

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented May 29, 2024

This PR removes reliance on the CosmosSDK to perform the migration and instead relies on the manifestd binary directly.

This change should improve the long-term maintenance of this project as we won't need to update this project every time a CosmosSDK change is introduced in manifest-ledger.

The manifestd binary should be present in the PATH of the host running mfx-migrator.

This PR also

  • Bumps Go to 1.22.4
  • Truncate any error output sent to Talib if it is longer than 8192 characters
  • Fixes the quarantine of failed migration

@fmorency fmorency self-assigned this May 29, 2024
@fmorency fmorency requested a review from jgryffindor May 29, 2024 17:13
@fmorency fmorency added the enhancement New feature or request label May 29, 2024
@fmorency fmorency marked this pull request as ready for review May 29, 2024 17:15
@fmorency fmorency merged commit 9981a0b into liftedinit:main Jun 27, 2024
3 checks passed
@fmorency fmorency deleted the decouple-migrate branch June 27, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant