Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add migration files to release archive #349

Merged
merged 2 commits into from
Mar 30, 2023
Merged

ci: add migration files to release archive #349

merged 2 commits into from
Mar 30, 2023

Conversation

fmorency
Copy link
Contributor

Fixes #343

@fmorency fmorency added enhancement New feature or request ci labels Mar 30, 2023
@fmorency fmorency requested review from hansl and jgryffindor March 30, 2023 14:52
@fmorency fmorency self-assigned this Mar 30, 2023
jgryffindor
jgryffindor reviewed Mar 30, 2023
View reviewed changes
Copy link

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, CircleCI artifact has the two migration files we currently need. Can we also please include ledger_state and kvstore_state?

@fmorency fmorency requested a review from jgryffindor March 30, 2023 20:17
@hansl
Copy link
Contributor

hansl commented Mar 30, 2023

My only major question would be why we don't auto-generate the migration file using the command line.

@fmorency
Copy link
Contributor Author

My only major question would be why we don't auto-generate the migration file using the command line.

That's a good idea! If you don't mind, let's create another issue/PR for that and unblock @jgryffindor with this PR.

@fmorency
Copy link
Contributor Author

#350

jgryffindor
jgryffindor approved these changes Mar 30, 2023
View reviewed changes
Copy link

@jgryffindor jgryffindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jgryffindor jgryffindor merged commit c4d75b5 into liftedinit:main Mar 30, 2023
@fmorency fmorency deleted the release-with-migrations branch March 30, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansl hansl hansl approved these changes

@jgryffindor jgryffindor jgryffindor approved these changes

Assignees

@fmorency fmorency

Labels
ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add migrations test files to artifacts
3 participants
@fmorency @hansl @jgryffindor