Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Call Tendermint client to retrieve transaction results when converting from Tendermint block to Many block #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MavenRain
Copy link
Contributor

This is a second attempt at adding transaction results to the Many blocks that are constructed from tendermint blocks in the abci module.

@MavenRain MavenRain requested review from hansl and fmorency December 22, 2022 18:52
@codecov-commenter
Copy link

Codecov Report

Merging #307 (2f3b5d6) into main (94f89d6) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   76.01%   75.90%   -0.11%     
==========================================
  Files          68       68              
  Lines        9371     9384      +13     
==========================================
  Hits         7123     7123              
- Misses       2248     2261      +13     
Impacted Files Coverage Δ
src/many-abci/src/module.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Can you add a test to make sure this works and that we won't break it later?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants