new_from_source should ref the source object #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcupitt
force-pushed
the
add-ref-to-new-from-source
branch
2 times, most recently
from
594f0a8 to
4381429
Compare
new_from_source needs to ref the ruby source wrapper, since the underlying C object will only ref the C source object also fix some issues in reference handling, and some lint errors see #384 thanks taylorthurlow
jcupitt
force-pushed
the
add-ref-to-new-from-source
branch
from
7738cf1 to
aaf7e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new_from_source needs to ref the ruby source wrapper, since the underlying C object will only ref the C source object
see #384
thanks taylorthurlow