Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom listener options #822

Merged
merged 7 commits into from
Dec 9, 2020
Merged

support custom listener options #822

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f2a954c
support custom listener options
lovemyliwu Dec 4, 2020
f0ad61f
fix get listener options
lovemyliwu Dec 4, 2020
da2bfab
add doc to explain custom listener options
lovemyliwu Dec 7, 2020
323c5ce
add ut
lovemyliwu Dec 7, 2020
5b00e25
fix code style
lovemyliwu Dec 7, 2020
9107146
Apply suggestions from code review
lovemyliwu Dec 8, 2020
ef97e36
add missing comma
lovemyliwu Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transport-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class TransportManager {
this.upgrader = upgrader
this._transports = new Map()
this._listeners = new Map()
this._listenerOptions = new Map()
this.faultTolerance = faultTolerance
}

Expand Down Expand Up @@ -47,6 +48,7 @@ class TransportManager {
})

this._transports.set(key, transport)
this._listenerOptions.set(key, transportOptions.listenerOptions || {})
if (!this._listeners.has(key)) {
this._listeners.set(key, [])
}
Expand Down Expand Up @@ -154,7 +156,7 @@ class TransportManager {
// For each supported multiaddr, create a listener
for (const addr of supportedAddrs) {
log('creating listener for %s on %s', key, addr)
const listener = transport.createListener({}, this.onConnection)
const listener = transport.createListener(this._listenerOptions[key], this.onConnection)
this._listeners.get(key).push(listener)

// We need to attempt to listen on everything
Expand Down