feat: discovery modules #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
reviewed
Nov 28, 2019
src/index.js
Outdated
| @@ -160,6 +160,7 @@ class Libp2p extends EventEmitter { | |||
| log('libp2p is starting') | |||
| try { | |||
| await this._onStarting() | |||
| this._isStarted = true | |||
There was a problem hiding this comment.
I think we should put this in _onDidStart as that keeps all post startup changes there.
src/index.js
Outdated
| // Peer discovery | ||
| if (this._modules.peerDiscovery) { | ||
| this._setupPeerDiscovery() | ||
| } |
There was a problem hiding this comment.
Is this if necessary? I think it would be good to have any necessary checks inside of _setupPeerDiscovery. I think it will be much easier for us to avoid bugs if we have the functions handle their checks.
vasco-santos
force-pushed
the
feat/discovery-modules
branch
from
d6e4171 to
810e89b
Compare
jacobheun
pushed a commit
that referenced
this pull request
Dec 12, 2019
* feat: discovery modules * chore: address review
jacobheun
pushed a commit
that referenced
this pull request
Jan 24, 2020
* feat: discovery modules * chore: address review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made necessary changes to integrate discovery modules, including the DHT random-walk.
Needs: