Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate transports with a reference to node #363

Merged
merged 3 commits into from
May 17, 2019
Merged

Instantiate transports with a reference to node #363

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc72be
Instantiate transports with a reference to creating node
guysv May 11, 2019
2921b34
Merge remote-tracking branch 'upstream/master' into pass-node-to-tran…
guysv May 17, 2019
5cf1c73
Satisfy linter
guysv May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ class Node extends EventEmitter {
let t

if (typeof Transport === 'function') {
t = new Transport()
t = new Transport({libp2p: this})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting fix:

Suggested change
t = new Transport({libp2p: this})
t = new Transport({ libp2p: this })

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the linting issue this looks fine. Travis is failing due to this and commitlint. I went ahead and disabled commitlint on master so it doesn't block tests going forward. If you rebase master and fix the linting issue I suggested above, travis tests should properly run.

I'll update the commit message on squash/merge.

} else {
t = Transport
}
Expand Down