This repository was archived by the owner on Jun 19, 2023. It is now read-only.
Initial pass at Transport._connect #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckousik
reviewed
Aug 5, 2022
ckousik
force-pushed
the
jt/con-428_dial
branch
from
1019ed8 to
c25b4df
Compare
| source: Source<Uint8Array> = pushable(); | ||
| sink: Sink<Uint8Array, Promise<void>>; | ||
| source: Source<Uint8ArrayList> = pushable(); | ||
| sink: Sink<Uint8ArrayList | Uint8Array, Promise<void>>; |
There was a problem hiding this comment.
@ckousik - please look at these changes, to be in compliance with the latest Stream interface
src/stream.ts:36:3 - error TS2416: Property 'sink' in type 'WebRTCStream' is not assignable to the same property in base type 'Stream'.
Type 'Sink<Uint8Array, Promise<void>>' is not assignable to type 'Sink<Uint8ArrayList | Uint8Array, Promise<void>>'.
Type 'Uint8ArrayList | Uint8Array' is not assignable to type 'Uint8Array'.
Type 'Uint8ArrayList' is missing the following properties from type 'Uint8Array': BYTES_PER_ELEMENT, buffer, byteOffset, copyWithin, and 21 more.
36 sink: Sink<Uint8Array, Promise<void>>;
|
@ckousik I think we can afford to merge this into develop at this point, agree? |
|
Should be good to merge
…On Wed, Aug 10, 2022, 21:08 John Turpish ***@***.***> wrote:
@ckousik <https://github.com/ckousik> I think we can afford to merge this
into develop at this point, agree?
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADB4QI2F4HLHVQM2CWIIMKDVYPEHZANCNFSM55WIUH2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
17 tasks
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.