This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Add "Factory" object with sensible defaults #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old webrtc-star had the star server encoded into the multiaddr Because the rendezvous point is optional now (actually there is no handling of a explicit server) the format tests needed a refresh
|
I would also comment that I believe that feat/use-interface-data-exchange belongs to a new transport, ideas for a new name? |
I suspect "libp2p-webrtc" will be sufficient |
|
Closing this as this is not relevant anymore with the latest release. Thanks for working on this @guysv |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, using libp2p/js-libp2p#363, I wrote a "factory" class for webrtc-star which handles the integration into libp2p nodes, and populates some of the WebRTCStar options with sensible defaults.