This repository was archived by the owner on Aug 23, 2019. It is now read-only.
fix: clear blacklist for peer when connection is established #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
requested review from
dirkmc and
vasco-santos
and removed request for
dirkmc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clears the blacklist for a peer when it established a muxed connection to the peer.
Previously, if you tried to connect to a peer that was temporarily unavailable, it would get blacklisted for a short period. If that peer came back online and connected to you, the blacklist wasn't getting cleared. This would prevent any application code from creating new streams to that peer because the dialer sees the blacklist. Incoming connections will now clear the blacklist to correct this.
Adding the test I also noticed the dialer queue
.addfunction was not exiting early when things were blacklisting, so I corrected that.