Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for unix multiaddr listen #10

Merged
merged 12 commits into from
Feb 26, 2019
Merged

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Feb 22, 2019

  • Changes the --sock flag to --listen and parses the passed string as a multiaddr.
  • Adds hostAddrs flag support
  • Adds announceAddrs flag support
  • Adds the libp2p-websocket transport to the daemon
  • Splits up tests into more specific files
  • All listening and connects are now done via multiaddr's
  • The daemon can now listen on tcp sockets, as well as unix paths
  • Testing on windows now leverages TCP
  • Register StreamHandler now takes a bytes multiaddr instead of a unix path. This now matches the go implementation

@jacobheun jacobheun force-pushed the feat/multiaddr-listen branch from 7782847 to c18db1c Compare February 25, 2019 15:37
@jacobheun jacobheun marked this pull request as ready for review February 25, 2019 15:49
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jacobheun

Just 2 small details and it should be ready to go. Don't forget to add a commit message with breaking change as the sock param will not be used anymore.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobheun jacobheun merged commit 9106d68 into master Feb 26, 2019
@jacobheun jacobheun deleted the feat/multiaddr-listen branch February 26, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants