-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcpreuse: fix Scope() for *tls.Conn #3181
Conversation
ac4f0cb
to
87125fc
Compare
@@ -17,6 +17,11 @@ func (c connWithScope) Scope() network.ConnManagementScope { | |||
return c.scope | |||
} | |||
|
|||
func (c *connWithScope) Close() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for failures in the http tls handshake for wss. The http server closes the connection when handshake fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because this lets us fix this specific issue in a patch release.
The real fix should be in #3182
Yet another interface embedding bug 😭