-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update quic-go to v0.39.1, set a static resumption token generator key #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1da13c8
to
f1ffb53
Compare
f986948
to
1592802
Compare
#2582 removes the metrics tracer, which is currently causing problems here. |
1592802
to
d4e1e8e
Compare
Updated the PR to v0.39.1. |
sukunrt
requested changes
Oct 17, 2023
Rebasing in the hope that this helps with flaky tests that @sukunrt recently fixed. |
3a6d0ee
to
dd036ae
Compare
sukunrt
requested changes
Oct 21, 2023
looks like the flaky fixes are working :) |
sukunrt
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on the v0.39.0 quic-go release, especially quic-go/quic-go#4066.