fix if order

libp2p · Aug 24, 2021 · 5cf36a6 · 5cf36a6
1 parent c317723
commit 5cf36a6
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/p2p/protocol/holepunch/coordination.go b/p2p/protocol/holepunch/coordination.go
@@ -113,13 +113,13 @@ func (hs *HolePunchService) HolePunch(rp peer.ID) error {
 			dt := time.Since(tstart)
 			cancel()
 
-			if err == nil {
-				hs.tracer.DirectDialSuccessful(rp, dt)
-				log.Debugf("direct connection to peer %s successful, no need for a hole punch", rp.Pretty())
-				return nil
+			if err != nil {
+				hs.tracer.DirectDialFailed(rp, dt, err)
+				break
 			}
-			hs.tracer.DirectDialFailed(rp, dt, err)
-			break
+			hs.tracer.DirectDialSuccessful(rp, dt)
+			log.Debugf("direct connection to peer %s successful, no need for a hole punch", rp.Pretty())
+			return nil
 		}
 	}