Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add advocates to libp2p #134

Merged
merged 2 commits into from
Mar 7, 2023
Merged

add advocates to libp2p #134

merged 2 commits into from
Mar 7, 2023

Conversation

2color
Copy link
Contributor

@2color 2color commented Mar 7, 2023

Summary

Add IPFS advocates to the libp2p org

Why do you need this?

libp2p/universal-connectivity#1

What else do we need to know?

DRI: @p-shahi

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@2color 2color requested review from a team as code owners March 7, 2023 09:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_membership.this["2color"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "2color"
    }

  # github_membership.this["thediscordian"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "TheDiscordian"
    }

  # github_team.this["community"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Developer advocates, community engineers, and other people that need write privs."
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "community"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["community:2color"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "2color"
    }

  # github_team_membership.this["community:thediscordian"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "TheDiscordian"
    }

Plan: 5 to add, 0 to change, 0 to destroy.

@p-shahi p-shahi merged commit f518c0b into libp2p:master Mar 7, 2023
@2color 2color deleted the patch-1 branch March 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants