-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type checking length units #3172
Type checking length units #3172
Conversation
…type-checking-length-units
#2326 ? |
@seven-phases-max please read issue #3023, which this PR resolves. |
#3023 is OK (see complete LU list below though), but could you please annihilate the https://www.w3.org/TR/css-values-3: em, ex, ch, rem, cm, mm, q, in, pt, pc, px, vw, vh, vmin, vmax P.S. Ideally the test should be case-insensitive (not a big deal usually, but counting they're using both |
@seven-phases-max sorry, I understand what you mean now. Please excuse my sleepy head late last night 😴 I'll refactor it to use |
Type checking length units
|
@seven-phases-max I have resolved your comments and updated my PR for issue #3172 :) |
Thanks! |
Thanks! I'll try to tag and push a release soon on NPM. |
Resolves issue: #3023 Incorrect type-checking for CSS length units