Skip to content

Commit

Permalink
Avoid breaking protobuf release for now
Browse files Browse the repository at this point in the history
Protobuf-java was upgraded to 4.28.2 to address google#4584.

The vulnerability
[CVE-2024-7254](GHSA-735f-pc8j-v9w8) is
fixed in protobuf-java 3.25.5, as initially suggested in google#4584.

Protobuf-java saw major breaking changes in 4.26, partially mitigated in
the 27 series. Because it takes time to adopt to these breaking changes,
it is better I think to only address the vulnerability and not jump into
the breaking releases yet.

Specifically, the problem is that now everyone that uses error-prone is
forced to jump to the breaking Protobuf releases today.

This includes all users of the chain of Google BOMs (libraries-bom,
first-party-dependencies, google-cloud-bom and
gapic-generator-java-bom). Those still reference 3.25.5 [1].

This PR fixes the issue. I think error-prone should then be released and
included in gapic-generator-java-pom-parent.

Thank you!

[1] https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java-pom-parent/pom.xml#L34
  • Loading branch information
lepistone committed Oct 23, 2024
1 parent 60c5f76 commit eb290f6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<maven-javadoc-plugin.version>3.3.1</maven-javadoc-plugin.version>
<maven-source-plugin.version>3.2.1</maven-source-plugin.version>
<nexus-staging-maven-plugin.version>1.6.13</nexus-staging-maven-plugin.version>
<protobuf.version>4.28.2</protobuf.version>
<protobuf.version>3.25.5</protobuf.version>
<grpc.version>1.43.3</grpc.version>
<jspecify.version>1.0.0</jspecify.version>
</properties>
Expand Down

0 comments on commit eb290f6

Please sign in to comment.