Merge pull request prisma-labs#6 from jgeschwendt/fix-backticks

fix(loader): escape backtick characters that may lie within comments
leosuncin · Mar 26, 2018 · 586e4ee · 586e4ee
2 parents b3dd9ba + 4f07e62
commit 586e4ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -5,5 +5,5 @@ export default function(source) {
 
   this.cacheable()
 
-  callback(null, `module.exports = \`${importSchema(source)}\``)
+  callback(null, `module.exports = \`${importSchema(source).replace(/`/g, '\\`')}\``)
 }
diff --git a/test/fixtures/a.graphql b/test/fixtures/a.graphql
@@ -1,3 +1,6 @@
+"""
+Comment with escaped `backticks`
+"""
 type A {
   id: ID!
   valueA: String

diff --git a/test/loader.test.ts b/test/loader.test.ts
@@ -14,6 +14,9 @@ const complex = `module.exports = \`type Complex {
   d: D!
 }
 
+"""
+Comment with escaped \\\`backticks\\\`
+"""
 type A {
   id: ID!
   valueA: String
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,9 @@ const complex = `module.exports = \`type Complex { @@
       d: D!
     }
+    """
+    Comment with escaped \\\`backticks\\\`
+    """
     type A {
       id: ID!
       valueA: String
@@ Expand Down @@