feat: Grant host engine control over memory #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed this when I renamed the file, should have been done in an earlier PR
It will shortly be used in the memory tests.
This will be used shortly by more tests. The extraction is still really really minimal - it does what it needs to do now and is no fancier. In the future we may want to do more with it, but not now. The code is a cut and paste, plus fixing the references to memory.
Adds a 'free' function to lenses, and gives the host engine control over when allocated memory is freed - right now this means memory is allocated immediately prior to passing items to the wasm module, and then freed when recieving the result. Tests are added in a later commit.
AndrewSisley
requested review from
nasdf,
jsimnz,
islamaliev,
fredcarle and
shahzadlone
AndrewSisley
changed the title
AndrewSisley
changed the title
AndrewSisley
force-pushed
the
62-free-mem
branch
2 times, most recently
from
938e9f7 to
60f9638
Compare
These tests do some basic testing of the memory management stuff.
AndrewSisley
force-pushed
the
62-free-mem
branch
from
60f9638 to
1c4a89c
Compare
|
Closing this for now, as the enumerable stuff (#33) will bring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #62
Description
Adds a new
freefunction to the wasm interface.This gives the host engine control over when allocated memory is freed - right now this means memory is allocated immediately prior to passing items to the wasm module, and then freed when receiving the result.