Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace swank with micros #691

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Replace swank with micros #691

merged 11 commits into from
Jun 6, 2023

Conversation

cxxxr
Copy link
Member

@cxxxr cxxxr commented Jun 6, 2023

Overview

This change corresponds to phase 1 and phase 2 of #688

I have replaced the part where I was using the swank package in lisp-mode with micros.
In addition, I had bundled micros, but have now switched it to a submodule.

Breaking change

Due to this change, it is no longer possible to connect to Swank.
Instead, we will use micros, and there are currently no differences in the API.

;; before
(swank:create-server :dont-close t :port <port-number>)

;; after
(micros:create-server :dont-close t :port <port-number>)

In addition, since I have added micros as a submodule, updating the submodule is necessary.

$ git submodule update --recursive

@cxxxr cxxxr marked this pull request as ready for review June 6, 2023 15:23
@cxxxr cxxxr merged commit b3f9d08 into main Jun 6, 2023
@vindarel
Copy link
Collaborator

vindarel commented Jun 8, 2023

Note for devs who had cloned Lem before, I needed:

git submodule update --init submodules/micros

thx

@cxxxr cxxxr deleted the replace-swank-with-micros branch June 21, 2023 17:18
@cxxxr cxxxr mentioned this pull request Jul 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants