Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed evt/spms to allow for event building with zero-suppression data #597

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

rosannadeckert
Copy link
Contributor

  • Fixed bug in hit/build_hit.py
  • Changed functions in evt/spms.py to account for data in zero-suppression mode, i.e. when each event has a different number of channels that triggered

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.63%. Comparing base (29d9b63) to head (bc3dbbb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/pygama/evt/modules/spms.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   48.68%   48.63%   -0.05%     
==========================================
  Files          60       60              
  Lines        7939     7947       +8     
==========================================
  Hits         3865     3865              
- Misses       4074     4082       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosannadeckert rosannadeckert marked this pull request as ready for review February 5, 2025 15:21
@gipert gipert merged commit e84c132 into legend-exp:main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants