Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument type of fit_enc_sigmas #128

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix argument type of fit_enc_sigmas #128

merged 1 commit into from
Mar 5, 2025

Conversation

fhagemann
Copy link
Contributor

I tried to test this fit_enc_sigmas by passing the second argument as (1.0:1.0:20.0)u"µs", but it failed.. this little change in the type of the argument type seems to fix it.

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.39%. Comparing base (391ed7e) to head (4a43dfa).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/filter_optimization.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   28.39%   28.39%           
=======================================
  Files          37       37           
  Lines        3564     3564           
=======================================
  Hits         1012     1012           
  Misses       2552     2552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks self-requested a review March 5, 2025 09:42
@theHenks theHenks added the bug Something isn't working label Mar 5, 2025
Copy link
Collaborator

@theHenks theHenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theHenks theHenks merged commit 6eece2d into main Mar 5, 2025
12 of 13 checks passed
@theHenks theHenks deleted the fix branch March 5, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants