Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: btc send transfer #3563

Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: btc send transfer #3563

merged 1 commit into from
Apr 24, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Apr 17, 2023

Try out this version of the Hiro Wallet - download extension builds.

This PR implements sendTransfer from btckit using the new rpc request api pattern. PR is also up in btckit to add the proposed request type. btckit-org/btckit#2

cc @mica000
Screen Shot 2023-04-20 at 4 10 41 PM

Screen Shot 2023-04-20 at 4 10 50 PM

Screen Shot 2023-04-20 at 4 10 59 PM

Screen Shot 2023-04-20 at 4 11 11 PM

@fbwoolf fbwoolf requested a review from kyranjamie April 17, 2023 20:55
@fbwoolf fbwoolf linked an issue Apr 17, 2023 that may be closed by this pull request
@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 790ca17 to 8de3cd7 Compare April 17, 2023 21:34
@vercel vercel bot temporarily deployed to Preview April 17, 2023 21:35 Inactive
@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 8de3cd7 to efde81b Compare April 19, 2023 21:57
@fbwoolf fbwoolf changed the title feat: btc sign transaction feat: btc send transfer Apr 19, 2023
@vercel vercel bot temporarily deployed to Preview April 19, 2023 22:00 Inactive
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Fara. This looks really good. Added some (fairly picky) thoughts on some styling and abstractions.

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 20, 2023

@kyranjamie appreciate the review, but most of this was just temp/placeholder code until I received actual designs. I'll go back thru it today knowing we want to release it and address your comments. Refactored.

@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from efde81b to 0873438 Compare April 20, 2023 21:15
@vercel vercel bot temporarily deployed to Preview April 20, 2023 21:16 Inactive
@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 0873438 to 82045fb Compare April 20, 2023 21:19
@vercel vercel bot temporarily deployed to Preview April 20, 2023 21:22 Inactive
@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 82045fb to 38c6da1 Compare April 20, 2023 21:37
@vercel vercel bot temporarily deployed to Preview April 20, 2023 21:38 Inactive
@fbwoolf fbwoolf marked this pull request as ready for review April 20, 2023 21:38
@fbwoolf fbwoolf requested a review from kyranjamie April 20, 2023 21:38
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 20, 2023

Ok @kyranjamie, let me have it! Opening for review ...addressed your first round of comments.

@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 38c6da1 to e14e8a6 Compare April 21, 2023 15:59
@vercel vercel bot requested a deployment to Preview April 21, 2023 16:01 Abandoned
@vercel vercel bot temporarily deployed to Preview April 21, 2023 16:01 Inactive
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but rebase as there are some new lint errors you might run into

@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from e14e8a6 to 40a20b0 Compare April 21, 2023 16:11
@vercel vercel bot temporarily deployed to Preview April 21, 2023 16:11 Inactive
@markmhendrickson
Copy link
Collaborator

@kyranjamie let's merge this in?

@kyranjamie kyranjamie added this pull request to the merge queue Apr 24, 2023
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 24, 2023

@kyranjamie let's merge this in?

This is waiting for btckit to be published so I can remove the hardcoded request types.

@kyranjamie kyranjamie removed this pull request from the merge queue due to a manual request Apr 24, 2023
@kyranjamie
Copy link
Collaborator

kyranjamie commented Apr 24, 2023

Let me do this first then. Published ✅

@markmhendrickson
Copy link
Collaborator

I'm actually getting an error while QA'ing:

Screenshot 2023-04-24 at 12 44 38

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 24, 2023

I'm actually getting an error while QA'ing:

I never ran into this, user error? 😆

EDIT: How are you testing?

@markmhendrickson
Copy link
Collaborator

I installed this PR's build then went to the test app then "Bitcoin" tab and "Send transfer" button having authenticated with the first account in my wallet (with positive mainnet and testnet BTC balances). Then got this error when selecting the mid-range fees level.

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Apr 24, 2023

Check out the "invalid base58 address" message:

tx.signing.mov

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Apr 24, 2023

Check out the "invalid base58 address" message:

Yeah, that button isn't how you test until the package update is installed. You have to test through the console ...it is likely fine once I swap out for the upgraded btckit release.

@fbwoolf fbwoolf force-pushed the feat/btc-sign-transaction branch from 40a20b0 to 34de347 Compare April 24, 2023 16:48
@vercel vercel bot temporarily deployed to Preview April 24, 2023 16:51 Inactive
@fbwoolf fbwoolf added this pull request to the merge queue Apr 24, 2023
Merged via the queue into dev with commit 7c7fdae Apr 24, 2023
@fbwoolf fbwoolf deleted the feat/btc-sign-transaction branch April 24, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support app requests to sign BTC transactions
3 participants