-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: btc send transfer #3563
feat: btc send transfer #3563
Conversation
790ca17
to
8de3cd7
Compare
8de3cd7
to
efde81b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Fara. This looks really good. Added some (fairly picky) thoughts on some styling and abstractions.
src/app/pages/rpc-sign-transaction/components/sign-transaction.layout.tsx
Outdated
Show resolved
Hide resolved
src/app/pages/rpc-send-transfer/components/send-transfer-actions.layout.tsx
Outdated
Show resolved
Hide resolved
src/app/pages/rpc-send-transfer/components/rpc-send-transfer.layout.tsx
Outdated
Show resolved
Hide resolved
src/app/pages/send/send-crypto-asset-form/family/bitcoin/hooks/use-generate-bitcoin-tx.ts
Outdated
Show resolved
Hide resolved
src/app/pages/rpc-send-transfer/rpc-send-transfer-choose-fee.tsx
Outdated
Show resolved
Hide resolved
|
efde81b
to
0873438
Compare
0873438
to
82045fb
Compare
82045fb
to
38c6da1
Compare
Ok @kyranjamie, let me have it! Opening for review ...addressed your first round of comments. |
38c6da1
to
e14e8a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but rebase as there are some new lint errors you might run into
src/app/components/bitcoin-fees-list/components/bitcoin-fees-list.layout.tsx
Outdated
Show resolved
Hide resolved
e14e8a6
to
40a20b0
Compare
@kyranjamie let's merge this in? |
This is waiting for btckit to be published so I can remove the hardcoded request types. |
Let me do this first then. Published ✅ |
I never ran into this, user error? 😆 EDIT: How are you testing? |
I installed this PR's build then went to the test app then "Bitcoin" tab and "Send transfer" button having authenticated with the first account in my wallet (with positive mainnet and testnet BTC balances). Then got this error when selecting the mid-range fees level. |
Check out the "invalid base58 address" message: tx.signing.mov |
Yeah, that button isn't how you test until the package update is installed. You have to test through the console ...it is likely fine once I swap out for the upgraded btckit release. |
40a20b0
to
34de347
Compare
This PR implements
sendTransfer
from btckit using the new rpc request api pattern. PR is also up in btckit to add the proposed request type. btckit-org/btckit#2cc @mica000
