Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding decimals when fees are shown in preview/send form, for BTC #3582

Closed
314159265359879 opened this issue Apr 21, 2023 · 0 comments · Fixed by #3583
Closed

Add padding decimals when fees are shown in preview/send form, for BTC #3582

314159265359879 opened this issue Apr 21, 2023 · 0 comments · Fixed by #3583
Labels
area:bitcoin area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@314159265359879
Copy link
Contributor

From suggestion here

LGTM sending low UTXO inscription was successful. I luv it!

One minor This fee (0.0000488 BTC) could easily be misinterpreted for 488 sats, but it is actually missing the 8th decimal because of rounding (I know this is common for balances). I see we are not doing that in the "choose fee" dialogue when three fees are shown all aight decimals of the BTC are shown, I like that.

Can we do the same here? Fee as shown now: image

Choose fee when sending regular BTC shows all 8 decimals: image
@314159265359879 314159265359879 added Enhancement 💡 enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives area:ui UI engineering specific tasks. area:bitcoin labels Apr 21, 2023
@github-project-automation github-project-automation bot moved this to Enhancements backlog in Hiro Wallet (DEPRECATED) Apr 21, 2023
kyranjamie added a commit that referenced this issue Apr 21, 2023
@kyranjamie
fix: pad decimals, closes #3582
9d6e50b
@kyranjamie kyranjamie mentioned this issue Apr 21, 2023
Merged
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Released in Hiro Wallet (DEPRECATED) Apr 24, 2023
@fbwoolf fbwoolf mentioned this issue Apr 24, 2023
Merged
blockstack-devops pushed a commit that referenced this issue Apr 26, 2023
@semantic-release-bot
chore(release): 4.18.0
fe5a810 
## [4.18.0](v4.17.0...v4.18.0) (2023-04-26)

### Features

* add btc balance in account selection total balance ([2a06e95](2a06e95))
* btc send transfer ([7c7fdae](7c7fdae))

### Bug Fixes

* **analytics:** exploring use of traits ([2fda5a3](2fda5a3))
* inability to remove network ([dcf3c40](dcf3c40))
* pad decimals, closes [#3582](#3582) ([1ccf7dd](1ccf7dd))
* send transfer success response ([6d12445](6d12445))
* stx and sip10 tx error routing ([c46797f](c46797f))
* tabular alignment of numberical amounts ([4cbce03](4cbce03))
* tx req edit nonce ([5871a95](5871a95))

### Internal

* force consistent interface style ([63714ca](63714ca))
* improve linting ([485bf6e](485bf6e))
* use consistent signing pattern, closes [#3405](#3405) ([8ea185a](8ea185a))
* using factory fn for signer ([541c3b7](541c3b7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:bitcoin area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add padded decimals, refactor tx signing leather-io/extension
1 participant
@314159265359879