Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Bug with long texts and media #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TamaroWalter
Copy link
Collaborator

@TamaroWalter TamaroWalter commented Sep 25, 2024

Pull Request for Issue #8

What was the problem?

  • The postletter.js cuts too long text and makes the original text appear with a show more button. The "cut"-function worked with the inner-HTML of the post-message and because of that it cutted within html-elements, that lead to this problem. In text-only messages this was not a problem, messages with videos and latex-commands it showed.

What is the current solution?

  • Instead of working with the message itself the functionality of cutting posts letters at a certain point is solved with css-styling. By restrict the height of the message-div to a certain limit and making it expandable with the "show more"-button, the same functionality is achieved without manipulating html-elements directly.

@TamaroWalter TamaroWalter self-assigned this Sep 25, 2024
@TamaroWalter TamaroWalter changed the title Solve Bug with long texts and media WIP: Solve Bug with long texts and media Sep 25, 2024
@TamaroWalter TamaroWalter changed the title WIP: Solve Bug with long texts and media Solve Bug with long texts and media Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant