Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr fixes the issue occurring where attempting to save searches resulted in the error:
Attempted to save CreatedChange change for savedsearch before setting channel_id and user_id.
This issue was fixed by adding
getUserId()
function to the ResourceSavedSearch
, usingsaved_by
param to set user id.This pr also adds a null check to the function
searchFilterCount()
withinSavedSearchedModal.vue
to ensureval
is not null before reaching the string processing step, avoiding errors onval.split
.Manual verification steps performed
Screenshots (if applicable)
SavedSearches.mov
Reviewer guidance
How can a reviewer test these changes?
References
Fixes #4577
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)