Merge pull request #4622 from shivam-daksh/fix-issue-#4606

Fix to issue #4606 : Links leading outside Studio need to have a pop out icon
learningequality · Aug 9, 2024 · 4570288 · 4570288
2 parents 0e6ed6c + 922b49e
commit 4570288
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/contentcuration/contentcuration/frontend/settings/pages/Account/index.vue b/contentcuration/contentcuration/frontend/settings/pages/Account/index.vue
@@ -49,7 +49,7 @@
       {{ $tr('apiTokenMessage') }}
       <KExternalLink
         href="https://ricecooker.readthedocs.io/en/latest/index.html"
-        target="_blank"
+        openInNewTab
         :text="$tr('apiDocumentation')"
         rel="noopener noreferrer"
       />
@@ -233,5 +233,4 @@
 .row {
   padding: 8px 0;
 }
-
-</style>
+</style>
diff --git a/contentcuration/contentcuration/frontend/settings/pages/Storage/index.vue b/contentcuration/contentcuration/frontend/settings/pages/Storage/index.vue
@@ -39,13 +39,12 @@
 
     <p>
 
-      <span>{{ $tr('requestMoreSpaceMessage') }}</span>
+      <span>{{ $tr('requestMoreSpaceMessage') + " " }}</span>
 
       <KExternalLink
-        style="display: inline;"
         :text="$tr('learnMoreAboutImportingContentFromChannels')"
         href="https://kolibri-studio.readthedocs.io/en/latest/add_content.html#import-content-from-other-channels"
-        target="_blank"
+        openInNewTab
       />
 
     </p>
@@ -161,4 +160,4 @@
     }
   }
 
-</style>
+</style>
diff --git a/contentcuration/contentcuration/frontend/settings/pages/UsingStudio/index.vue b/contentcuration/contentcuration/frontend/settings/pages/UsingStudio/index.vue
@@ -29,8 +29,9 @@
     </p>
     <p>
       <KExternalLink
+        class="kexternal-redirect"
         href="https://kolibri-studio.readthedocs.io/en/latest/index.html"
-        target="_blank"
+        openInNewTab
         :text="$tr('userDocsLink')"
         rel="noopener noreferrer"
       />
@@ -50,9 +51,10 @@
         <li>{{ $tr('bestPractice5') }}</li>
         <li>
           <KExternalLink
+            class="kexternal-redirect"
             href="https://ricecooker.readthedocs.io/en/latest/video_compression.html"
             :text="$tr('bestPractice6')"
-            target="_blank"
+            openInNewTab
             rel="noopener noreferrer"
           />
         </li>
@@ -64,16 +66,18 @@
     <!-- Issues -->
     <h2>{{ $tr('notableIssues') }}</h2>
     <KExternalLink
+      class="kexternal-redirect"
       href="https://github.com/learningequality/studio/issues/3992"
       :text="$tr('issueLink1')"
-      target="_blank"
+      openInNewTab
       rel="noopener noreferrer"
     />
     <p>{{ $tr('issue1') }}</p>
     <KExternalLink
+      class="kexternal-redirect"
       href="https://github.com/learningequality/studio/issues"
       :text="$tr('issuesPageLink')"
-      target="_blank"
+      openInNewTab
       rel="noopener noreferrer"
     />
   </div>
@@ -141,4 +145,7 @@
   h2 {
     margin-top: 32px;
   }
-</style>
+  .kexternal-redirect{
+    margin-left: -8px;
+  }
+</style>