Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13033: CategorySearchModal Bugs #13055

Closed
wants to merge 1 commit into from

Conversation

adiitxa
Copy link

@adiitxa adiitxa commented Feb 6, 2025

Summary

References

Reviewer guidance

Summary

Fixes bugs in the CategorySearchModal component, resolving rendering issues on large screens and display problems in side panels (Learn/Coach). Modifications include updating handleCategory, adjusting the v-if condition, and correcting CSS for side panel views.

Verification

Tested CategorySearchModal in all views (large screen, Learn/Coach side panels) across categories with/without subcategories. Confirmed correct rendering and functionality.

References

Reviewer guidance

Please verify CategorySearchModal functionality in all views, especially side panels.

Changes made file path

https://github.com/learningequality/kolibri/blob/5bf546e7e63bac87df02242ca25be022dfe5af98/packages/kolibri-common/components/SearchFiltersPanel/index.vue#L146%7Chttps://github.com/learningequality/kolibri/blob/5bf546e7e63bac87df02242ca25be022d%5B%E2%80%A6%5Dpackages/kolibri-common/components/SearchFiltersPanel/index.vue

@MisRob
Copy link
Member

MisRob commented Feb 7, 2025

Hello @adiitxa, welcome.

We won't be able to accept this pull request.

First and foremost, the issue #13033 is not open for contribution and as you can see in it, it is already assigned to a team member who has work in progress. Following CONTRIBUTING.md will help you to understand the contributing process and avoid this in the future.

I appreciate that you tested your fixes manually. Even though I can't say with certainty, code itself has appearance of having been generated by a large-language-model tool. I have a work-in-progress guidance on using such tools and if that's indeed the case, I think some points could help you to use it in a productive manner and contribute successfully in the future:

Screenshot from 2025-02-07 05-06-30

@MisRob MisRob closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants