Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In package.json, vinyl shoulud be placed in dependencies #119

Closed
danielzhang5566 opened this issue Apr 28, 2021 · 2 comments · Fixed by #120
Closed

In package.json, vinyl shoulud be placed in dependencies #119

danielzhang5566 opened this issue Apr 28, 2021 · 2 comments · Fixed by #120

Comments

@danielzhang5566
Copy link

devDependencies is used to save the package for development purpose. Example: unit tests, minification.
dependencies is used to save the package required for the application to run.

in our gulp-replace/index.js :

const Vinyl = require('vinyl')

however, in our gulp-replace/package.json:

{
    "devDependencies": {
      "vinyl": "^2.2.1"
    }
    ...
}

vinyl shoulud be placed in dependencies rather than devDependencies, otherwise gulp-replace couldn't work.

@lazd
Copy link
Owner

lazd commented Apr 28, 2021

@jon2180 FYI

@lazd lazd closed this as completed in #120 Apr 28, 2021
lazd pushed a commit that referenced this issue Apr 28, 2021
This commit fixes #119
@lazd
Copy link
Owner

lazd commented Apr 28, 2021

Fixed in 1.1.2, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants