Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

if the client is already ready, waitUntilReady() should resolve #89

Merged
merged 1 commit into from
May 3, 2018
Merged

if the client is already ready, waitUntilReady() should resolve #89

merged 1 commit into from
May 3, 2018

Conversation

dylanjha
Copy link
Contributor

@dylanjha dylanjha commented May 3, 2018

closes #78

@dylanjha dylanjha mentioned this pull request May 3, 2018
Closed
@apucacao apucacao self-requested a review May 3, 2018 15:23
apucacao
apucacao approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@apucacao apucacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylanjha — this looks good to me. I'll merge this now and release 4.0.5 shortly.

@apucacao apucacao merged commit 41ac5a8 into launchdarkly:master May 3, 2018
@apucacao apucacao mentioned this pull request May 3, 2018
Merged
@dylanjha
Copy link
Contributor Author

dylanjha commented May 3, 2018

@apucacao thanks for your speedy attention!

eli-darkly added a commit that referenced this pull request Aug 1, 2018
@eli-darkly
Merge pull request #89 from launchdarkly/eb/19705/400-error
0484c64 
treat HTTP 400 as a recoverable error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apucacao apucacao apucacao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

waitUntilReady never settles
2 participants
@dylanjha @apucacao