Merge of #3427 (by @mpyw) and #3614 (by @bonsairobo) #3765
Merged
+494
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite implementation is currently WIP
I have included `AtomicUsize` in `WorkerSharedState`. Ideally, it is not desirable to execute `load` and `fetch_add` in two separate steps, but we decided to allow it here since there is only one thread writing. To prevent writing from other threads, the field itself was made private, and a getter method was provided with `pub(crate)`.
This patch completes the plumbing of an optional statement from these methods to `TransactionManager::begin` without any validation of the provided statement. There is a new `Error::InvalidSavePoint` which is triggered by any attempt to call `Connection::begin_with` when we are already inside of a transaction.
…nts are successful
This makes the new method a non-breaking change.
Move the wrapper directly into the test that uses it instead.
…' into 3614-rebased
…an/begin-with' into 3614-rebased # Conflicts: # sqlx-core/src/connection.rs # sqlx-postgres/src/transaction.rs # sqlx-sqlite/src/connection/worker.rs # sqlx-sqlite/src/transaction.rs
# Conflicts: # sqlx-mysql/src/any.rs # sqlx-postgres/src/any.rs # sqlx-sqlite/src/connection/mod.rs # tests/sqlite/sqlite.rs
abonander
changed the title
|
I've decided that it would be best to limit the public interface of #3427 to just |
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #3427 (by @mpyw) and #3614 (by @bonsairobo).
These both touch a lot of the same code and I didn't want to continually bother both authors with requests to rebase.