Make assembly compatible with clang #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVMs Integrated Assembler did not accept the original syntax
CNugteren
approved these changes
Apr 1, 2022
|
This can be merged after #721 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The syntax used in the inline assembly of the 32-bit ARM kernels was not compatible with the LLVM Integrated Assembler. A workaround was to use
clang -fno-integrated-asbut that makes things complex when crosscompiling andPATHis not setup correctly.This PR uses the syntax that's also used in the ARM documentation; example.
How Has This Been Tested?
CI tests the correctness of this kernel.