Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added section about strict-mode to how-to-use #1265

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Mar 9, 2023

No description provided.

@erezsh erezsh requested a review from MegaIng March 9, 2023 14:12
Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Side note: I am currently looking through the hundreds of lark grammars available on github and found out that sometimes the current example generation algorithm can sometimes take multiple GBs of memory and take a few dozen seconds to actually find something, even if the intersection test was very fast. I gotta change that...

@erezsh erezsh merged commit d956958 into master Mar 9, 2023
@erezsh
Copy link
Member Author

erezsh commented Mar 9, 2023

Cool, well done on taking the initiative and testing them.

I think it will come down to either optimizing the algorithm, or setting a maximum number of steps, after which it exits without an example.

@MegaIng
Copy link
Member

MegaIng commented Mar 9, 2023

I will actually do both I think. Stopping after a certain number of steps is easy and reliable no matter how the exact regex(es) look like. Optimizations can only provide so much I think, it will always be possible to create a very slow example I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants