Fix: Add tests for Invoice::isDeleted()
#1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/deleted
branch
from
d6f44a5 to
03dc196
Compare
localheinz
commented
Aug 30, 2023
| $stripeInvoice = new StripeInvoice(); | ||
|
|
||
| $stripeInvoice->customer = $customerId; | ||
| $stripeInvoice->status = StripeInvoice::STATUS_DELETED; |
There was a problem hiding this comment.
Note that Stripe\Invoice::STATUS_DELETED has been deprecated since stripe/stripe-php:10.12.0 and has been removed with stripe/stripe-php:^12.0.0.
localheinz
force-pushed
the
fix/deleted
branch
from
03dc196 to
cbb25e9
Compare
localheinz
commented
Aug 30, 2023
|
|
||
| $invoice = new Invoice($user, $stripeInvoice); | ||
|
|
||
| $this->assertFalse($invoice->isDeleted()); |
There was a problem hiding this comment.
I don't know if anyone uses this method, but in the light of #1556, it either
- should always return
false - be deprecated and eventually removed
localheinz
force-pushed
the
fix/deleted
branch
from
cbb25e9 to
3881124
Compare
localheinz
changed the title
isDeleted()Invoice::isDeleted()
localheinz
force-pushed
the
fix/deleted
branch
from
3881124 to
5e9be47
Compare
|
Hi there @localheinz. I'm going to revert this one as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Somewhat related to #1556.