Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: disable default view events #646

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jrmoulton
Copy link
Collaborator

not a breaking change. unless code adds id.disable_default_event, no behavior of event handling will change

@jrmoulton jrmoulton marked this pull request as draft October 27, 2024 07:47
@jrmoulton jrmoulton force-pushed the add-disable-default-events branch from 48ad911 to 23f5368 Compare October 27, 2024 07:49
@jrmoulton jrmoulton marked this pull request as ready for review October 27, 2024 07:51
@jrmoulton
Copy link
Collaborator Author

jrmoulton commented Oct 29, 2024

any opposition to merging this?

@dzhou121
Copy link
Contributor

What’s the use case for this?

@jrmoulton
Copy link
Collaborator Author

I have a text_input that I want to not process any events, but I don't want to mark it as disabled because that will stop it from being able to be focused using the keyboard and tab.

@jrmoulton
Copy link
Collaborator Author

https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault

@dzhou121 dzhou121 merged commit 2be12bd into lapce:main Oct 29, 2024
10 of 12 checks passed
@jrmoulton jrmoulton deleted the add-disable-default-events branch October 29, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants