Add custom style trait #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhou121
reviewed
Aug 6, 2024
dzhou121
reviewed
Aug 6, 2024
jrmoulton
force-pushed
the
custom-style-trait
branch
from
b686a69 to
d661a82
Compare
|
I've removed the custom style trait and just used Default and Into |
jrmoulton
force-pushed
the
custom-style-trait
branch
from
d661a82 to
f8ede0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that external crates can implement custom style updaters in an efficient way. Previous implementations in floem had access to private items. Now the default implementation of the trait has access to those items and provides the updater.
This also makes the API for custom styles more consistent.