forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[kitsune] Fixes to support building only a subset of targets (#58)
This should really be more than one patch because there are several unrelated issues here. - The kitsune tests look for a label identifying the linker executable, then check the same line to ensure that the correct libraries are present. Checking the linker reliably is a hassle because it can be very different depending on the platform (even within Linux'es, it can vary, and that is even before using LLD). The, admittedly suboptimal, changes here simply remove the check for the linker executable and assume that the line immediately following the compile line is the link line and check for linker flags/libraries there. It should work unless something major changes in clang which is, hopefully, unlikely. - If the Cuda target has not been enabled, Kitsune will fail to build because CudaABI.cpp expects to find certain variables. This could be a more general problem with the other ABI's as well, so we don't build them unless they have been enabled. - Because kitsune/ is only processed after the subdirectories of llvm/, the KITSUNE_*_ENABLED variables are not set when llvm/lib/Transforms/Tapir is processed, so we will not be able to determine which Tapir targets have been enabed. All the code to do that is moved from kitsune/CMakeLists.txt to llvm/CMakeLists.txt. It would be good if we could find a way to keep all the kitsune cmake code isolated, from the rest of LLVM's cmake, but this should be manageable during merges. - The names of the variables were changed from KITSUNE_*_ENABLE to KITSUNE_*_ENABLED (note the added trailing D) for consistency with the rest of the code.
- Loading branch information
1 parent
e0179cc
commit 3770907
Showing
32 changed files
with
271 additions
and
192 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,25 @@ | ||
# Kitsune support | ||
# Kitsune support | ||
kitsune_install_prefix:=${CMAKE_INSTALL_PREFIX} | ||
|
||
# Cuda support | ||
kitsune_cuda_enable:="${KITSUNE_CUDA_ENABLE}" | ||
# Cuda support | ||
kitsune_cuda_enable:="${KITSUNE_CUDA_ENABLED}" | ||
ifeq ($(kitsune_cuda_enable),"ON") | ||
$(info config: cuda target enabled.) | ||
KITSUNE_CUDA_ENABLE:=true | ||
KITSUNE_CUDA_ENABLED:=true | ||
endif | ||
|
||
# Hip support | ||
kitsune_hip_enable:="${KITSUNE_HIP_ENABLE}" | ||
# Hip support | ||
kitsune_hip_enable:="${KITSUNE_HIP_ENABLED}" | ||
ifeq ($(kitsune_hip_enable),"ON") | ||
$(info config: hip target enabled.) | ||
KITSUNE_HIP_ENABLE:=true | ||
KITSUNE_HIP_ENABLED:=true | ||
ROCM_PATH:=${ROCM_PATH} | ||
endif | ||
endif | ||
|
||
# Kokkos support | ||
kitsune_kokkos_enable:="${KITSUNE_KOKKOS_ENABLE}" | ||
# Kokkos support | ||
kitsune_kokkos_enable:="${KITSUNE_KOKKOS_ENABLED}" | ||
ifeq ($(kitsune_kokkos_enable),"ON") | ||
$(info config: kokkos codegen enabled.) | ||
KITSUNE_KOKKOS_ENABLE:=true | ||
KITSUNE_KOKKOS_ENABLED:=true | ||
endif | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.